[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #40 from Jesus Sanchez-Palencia <jesus at webkit.org>  2012-10-11 06:08:47 PST ---
(In reply to comment #39)
> I want to use 'WebSocketServer' using g_socket_service on efl port.
> Should I copy WebSocketServerGtk.cpp to WebSocketServerEfl.cpp? or make a shareable directory for gtk/efl?

I would go for a shared implementation inside WebKit2/UIProcess/InspectorServer/soup/ (ok, I know it will be GSocket but why not following the convention of WebCore/platform/network/soup), if EFL is gonna use a GSocket based implementation as well.

And, as I've commented on the patch, you will be able to avoid stuff like:
"#elif PLATFORM(GTK) || PLATFORM(EFL)" by using "USE(SOUP)" instead.

In fact, from another glance at the patch, the only thing that might change in between the ports is the implementation of WebInspectorServer::platformResourceForPath .

IMO, all of these could still be fixed on this patch since it is still waiting for review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.