[Webkit-unassigned] [Bug 98874] [GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 00:47:43 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=98874





--- Comment #9 from Mario Sanchez Prada <msanchez at igalia.com>  2012-10-11 00:48:23 PST ---
(From update of attachment 167969)
View in context: https://bugs.webkit.org/attachment.cgi?id=167969&action=review

Looks good to me. Now I think it's time someone else performed an official review.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:295
>          return;

I definitely like more this early return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list