[Webkit-unassigned] [Bug 98728] [Texmap] Swizzling BGRA to RGBA in temp buffer while USE(TEXMAP_OPENGL_ES_2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98728


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167746|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-10-10 20:44:35 PST ---
(From update of attachment 167746)
View in context: https://bugs.webkit.org/attachment.cgi?id=167746&action=review

In some cases it's ok to swizzle the actual data (when it's a backing store for a temporary ImageBuffer), and in some cases it's not (when it's a directly composited image). We should add an enum parameter to updateContents that stands for whether it's ok to swizzle the actual data without copying.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:726
> +        void* srcData = reinterpret_cast<void *>(const_cast<char*>(imageData));

why do you need srcData? If you're copying, you can use imageData directly...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.