[Webkit-unassigned] [Bug 98504] [CSS Shaders] Implement overlay, color-dodge, color-burn, hard-light, soft-light blend modes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98504





--- Comment #5 from Huang Dongsung <luxtella at company100.net>  2012-10-10 01:56:30 PST ---
(From update of attachment 167959)
View in context: https://bugs.webkit.org/attachment.cgi?id=167959&action=review

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:234
> +        blendComponentExpression = SHADER(

I don't check the divide by zero, because 1.0 - Cs can not zero if Cs < 1.0.
I don't use clamp, because we are checking Cs < 1.0, not Co < 1.0. (clamp(genIType x, genIType  minVal, genIType  maxVal))
Please let me know if I misunderstand your suggestion.

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:248
> +        blendComponentExpression = SHADER(

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.