[Webkit-unassigned] [Bug 98733] [WK2] Add CustomFilterOperation serialization in ArgumentCoder.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98733





--- Comment #10 from Huang Dongsung <luxtella at company100.net>  2012-10-09 21:01:52 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (From update of attachment 167854 [details] [details] [details])
> > > I don't think we want to allow sending arbitrary shader strings from the web process to the UI process.
> > 
> > We want to allow this for coordinated graphics (Qt/EFL).
> > Any opposition to doing this if it's guarded with USE(COORDINATED_GRAPHICS)?
CSS_FILTERS and CSS_SHADERS guard are already in the USE(COORDINATED_GRAPHICS).

> 
> Though in any case we would want to validate the shader first, and then serialize the CustomFilterValidatedProgram.

Thank Anders and Noam for very valid concerns.

The most critical requirement is that UI TexMap never execute author's arbitrary shaders.

I think there are two solutions:
1. As Noam mentioned, validate the shader first, and then serialize the CustomFilterValidatedProgram.
2. Serialize CustomFilterProgram, and validate the shader using CustomFilterValidatedProgram.

I prefer the second solution, because :
1. Texmap will receive CustomFilterOperation that has CustomFilterProgram as a member variable.
2. We can validate arbitrary shaders using ANGLE validator with the SH_CSS_SHADERS_SPEC flag like CustomFilterValidatedProgram does.
3. Texmap can reuse many custom filter classes without huge refactoring.

I support the third reason.
createCustomFilterEffect() in FilterEffectRenderer makes CustomFilterValidatedProgram and FECustomFilter from CustomFilterOperation. FECustomFilter plays a all role to render css shaders.
I think TexMap reuse FECustomFilter to render css shaders because TexMap can have CustomFilterProgram though we need to refactor FECustomFilter little. In conclusion, if we choose the second solution, we can enable css shaders in TexMap reusing existing custom filter classes.

If you don't mind, I want to enable css shaders in TexMap soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.