[Webkit-unassigned] [Bug 98823] New: http://www.robohornet.org/tests/addcol.html spends 15% of time in HTMLTableRowsCollection::rowAfter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98823

           Summary: http://www.robohornet.org/tests/addcol.html spends 15%
                    of time in HTMLTableRowsCollection::rowAfter
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: rniwa at webkit.org
            Blocks: 98798


http://www.robohornet.org/tests/addcol.html spends 15% of time in HTMLTableRowsCollection::rowAfter

This also results in around 10% of all samples in "RoboHornetPro" (Microsoft's fork).

Ryosuke suggests that we're invalidating the collection too eagerly (on every td addition) even though it should only need to be invalidated when we add a row.  He mentions that HTMLCollection already knows how to only pay attention to direct children:
static bool shouldOnlyIncludeDirectChildren(CollectionType type)
and that invalidation just needs to be taught about that method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.