[Webkit-unassigned] [Bug 93922] [Shadow DOM] Insertion points need resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93922





--- Comment #5 from Takashi Sakamoto <tasak at google.com>  2012-10-08 23:17:22 PST ---
(From update of attachment 167277)
View in context: https://bugs.webkit.org/attachment.cgi?id=167277&action=review

Thank you for reviewing.

>> Source/WebCore/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Oops :)

I'm sorry. I forgot to update ChangeLogs. 
Done.

>> Source/WebCore/css/StyleResolver.cpp:1232
>> +    }
> 
> This seems forced. Can you help me understand why the styles of the insertion point wouldn't implicitly have this information? Presumably, their styles have already been computed and they already have the correctly reset inheritance.

I think, as insertion points don't have any renderers, insertion points don't have any render styles.
I know, it is possible for some element to have render styles without any renderers, i.e. implementing its own nonRendererRenderStyle method. 
However currently insertion points uses default nonRenderRenderStyle which just returns 0.
Talking about render styles, currently no information about reset-style-inheritance is added to render styles.

>> LayoutTests/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Oops :)

Sorry. Done.

>> LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:10
>> +FAIL window.getComputedStyle(document.getElementById("reset-style-inheritance-dynamic").firstChild).color should be rgb(0, 0, 0). Was rgb(255, 238, 238).
> 
> Why'd we fail this?

I see. This is a bug of insertion-point-resetStyleInheritance.html. I fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.