[Webkit-unassigned] [Bug 96627] [EFL] Use the shareable GraphicsContext3DOpenGL* implementation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 18:50:23 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96627





--- Comment #27 from Regina Chung <heejin.r.chung at samsung.com>  2012-10-08 18:50:57 PST ---
(In reply to comment #25)
> (From update of attachment 167522 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167522&action=review
> > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:56
> > +    , m_compiler(isGLES2Compliant() ? SH_ESSL_OUTPUT : SH_GLSL_OUTPUT)
> > +    , m_attrs(attrs)
> > +    , m_texture(0)
> > +    , m_compositorTexture(0)
> > +    , m_fbo(0)
> > +#if USE(OPENGL_ES_2)
> > +    , m_depthBuffer(0)
> > +    , m_stencilBuffer(0)
> > +#endif
> So some of the GLES2 support is build in using ifdefs and some is runtime? isGLES2Compliant?

The implementation of isGLES2Compliant() is actually defined using ifdefs.
I think the API exists to keep the ifdefs local (in platform/graphics).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list