[Webkit-unassigned] [Bug 98692] New: Modify LayoutState ASSERTS to support SATURATED_LAYOUT_ARITHMETIC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98692

           Summary: Modify LayoutState ASSERTS to support
                    SATURATED_LAYOUT_ARITHMETIC
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eae at chromium.org
                CC: abarth at webkit.org, inferno at chromium.org,
                    leviw at chromium.org
            Blocks: 95053


We currently overflow/wrap when computing the delta in RenderBlock::setLogicalTopForChild in cases where we have an element width a width or height exceeding maxLayoutUnit. When the delta is later added back in RenderBlock::layoutBlockChild the number wraps again getting us back to the correct value.

With SATURATED_LAYOUT_ARITHMETIC enabled the values no longer wraps, which seems like the correct thing to do however this causes the compare to fail for obvious reasons. By accounting for this we can keep the asserts (which have proven very helpful) even when SATURATED_LAYOUT_ARITHMETIC is turned on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.