[Webkit-unassigned] [Bug 98684] New: SVGResourcesCache::addResourcesFromRenderObject should not allocate SVGResources unconditionally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98684

           Summary: SVGResourcesCache::addResourcesFromRenderObject should
                    not allocate SVGResources unconditionally
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: zimmermann at kde.org, krit at webkit.org, pdr at google.com


SVGResourcesCache::addResourcesFromRenderObject should not allocate SVGResources unconditionally

malloc() is very expensive.

addResourcesFromRenderObject unconditionally malloc's an SVGResources object, even though its not needed much of the time.

This causes fastMalloc to be one of the top samples in PerformanceTests/SVG/SvgNestedUse.html

Fixing this is a slightly involved change, as we'll either need to make SVGResources::buildCachedResources static, and return a PassOwnPtr<SVGResources> or we need a separate method to check if we need an SVGResources in the first place.

Relatedly, I think buildCachedResources is too long, and could be cleaned up to be more readable. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.