[Webkit-unassigned] [Bug 98645] New: MSVC build try to use make instead of nmake with Qt5-r37

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98645

           Summary: MSVC build try to use make instead of nmake with
                    Qt5-r37
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zarvai at inf.u-szeged.hu
                CC: vestbo at webkit.org, ossy at webkit.org


After switching MSVC build to Qt5-r37 (749b83f337ec82eff305ed8ac85473ad984c84fa) a build error occurred:

WebKit is now configured for building. Just run 'make'.
Last built revision was unknown, now at revision 130570. Full incremental build needed.
Calling 'make  -j8 incremental' in C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\WebKitBuild\Release
'make' is not recognized as an internal or external command,
operable program or batch file.

Wrong make command is used. It should be nmake instead of make.

The problem caused by qmake.conf and webkitdirs.pm.

Qt5.0.0-r37-angle\mkspecs\default\qmake.conf contains:
QMAKESPEC_ORIGINAL = C:/WebKitBuildSlave/Qt5.0.0-r37-source/qt5/qtbase/mkspecs/win32-msvc2010
include($$QMAKESPEC_ORIGINAL/qmake.conf)

WebKit\Tools\Scripts\webkitdirs.pm contains a function called retrieveQMakespecVar. 
This function parses qmake.conf. It can follow includes, but it can not resolve variables.

The workaround for this issue is changing qmake.conf to the old value:
QMAKESPEC_ORIGINAL = C:/WebKitBuildSlave/Qt5.0.0beta1-source/qt5/qtbase/mkspecs/win32-msvc2010
include(../win32-msvc2010/qmake.conf)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.