[Webkit-unassigned] [Bug 98551] TestResultsServer does not display sync_integration_tests results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98551


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jparent at google.com,
                   |                            |ojan at chromium.org




--- Comment #1 from Ojan Vafai <ojan at chromium.org>  2012-10-05 13:57:47 PST ---
Your patch needs a ChangeLog description. Normally it would need a test too, but I think this change is basically covered by existing tests. You should include a line about why you don't need a test in the ChangeLog description.

See the section on ChangeLogs at http://www.webkit.org/coding/contributing.html.

I recommend using "Tools/Scripts/webkit-patch upload --request-commit" to upload the patch as that will autogenerate the ChangeLog boilerplate for you and properly mark this patch as needing code review + commit queue once it's been approved.

What I told you in email about not needing to change the groups for this test suite was technically wrong since I see now that they only run on the main Chromium waterfall, but I think it's fine to leave the patch as is (less code complexity than adding a new group). If people try to pick one of the other groups, they'll just get an empty dashboard page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.