[Webkit-unassigned] [Bug 93922] [Shadow DOM] Insertion points need resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93922


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167277|review?                     |review-
               Flag|                            |




--- Comment #3 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-10-05 11:19:36 PST ---
(From update of attachment 167277)
View in context: https://bugs.webkit.org/attachment.cgi?id=167277&action=review

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Oops :)

> Source/WebCore/css/StyleResolver.cpp:1232
> +    for ( ; insertionPoint; ) {
> +        InsertionPoint* youngerInsertionPoint = shadow->insertionPointFor(insertionPoint);
> +        if (!youngerInsertionPoint)
> +            break;
> +        insertionPoint = youngerInsertionPoint;
> +    }

This seems forced. Can you help me understand why the styles of the insertion point wouldn't implicitly have this information? Presumably, their styles have already been computed and they already have the correctly reset inheritance.

> LayoutTests/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Oops :)

> LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:10
> +FAIL window.getComputedStyle(document.getElementById("reset-style-inheritance-dynamic").firstChild).color should be rgb(0, 0, 0). Was rgb(255, 238, 238).

Why'd we fail this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.