[Webkit-unassigned] [Bug 98497] [GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98497





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-05 08:29:15 PST ---
(In reply to comment #2)
> (From update of attachment 167280 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167280&action=review
> 
> Looks good, but please see below before landing...
> 
> > Source/WebKit2/ChangeLog:9
> > +        The problem is that GTK+ tries to write in the io channel that ash
> > +        already been closed.
> 
> Nit: IO channel that has

Sure.

> > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:700
> > +        cairo_surface_finish(surface);
> 
> Since this is a work-around for a GTK+ bug it's probably a good idea to put a comment here including  a URL to the GTK+ bug in question.

It's not exactly a workaround, it's a good idea to do that in any case even if there weren't bugs in GTK+, we are already doing it in WebPrintOperationGtkUnix::endPrint() and it's reason why it didn't fail for other printing errors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.