[Webkit-unassigned] [Bug 98497] [GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98497


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167280|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-10-05 08:22:05 PST ---
(From update of attachment 167280)
View in context: https://bugs.webkit.org/attachment.cgi?id=167280&action=review

Looks good, but please see below before landing...

> Source/WebKit2/ChangeLog:9
> +        The problem is that GTK+ tries to write in the io channel that ash
> +        already been closed.

Nit: IO channel that has

> Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:700
> +        cairo_surface_finish(surface);

Since this is a work-around for a GTK+ bug it's probably a good idea to put a comment here including  a URL to the GTK+ bug in question.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.