[Webkit-unassigned] [Bug 80794] :first-line pseudo selector ignoring words created from :before

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80794





--- Comment #24 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-10-05 05:09:28 PST ---
(In reply to comment #23)
> (From update of attachment 167255 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167255&action=review
> 
> > Source/WebCore/rendering/RenderObject.cpp:2607
> > +static PassRefPtr<RenderStyle> firstLineStyleForCachedUncachedType(StyleCacheState type, const RenderObject* renderer, RenderStyle* style)
> 
> This method name is confusing. Instead rename firstLineStyleSlowCase to cachedFirstLineStyle and fix the one usage of it in the header and then rename this firstLineStyle(type,renderer,style)

Hi Elliott. I agree the new name doesn't seem right but had used it anyway for want of a better name, since firstLineStyle() is already in use (as part of RenderObject).
I understand the newly added function is a static and hence I can still get away with using the same name for it as well i.e. firstLineStyle but just wanted to confirm once whether that would be the correct way to go about it.

Also, firstLineStyleSlowCase name should be changed as well and cachedFirstLineStyle definitely seems more appropriate but should that be spawned off as a separate bug and not be made a part of this patch? Just wondering.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.