[Webkit-unassigned] [Bug 97875] EventHandler should not use shadowAncestorNode()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 11:57:16 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=97875





--- Comment #2 from Daniel Bates <dbates at webkit.org>  2012-10-04 11:57:43 PST ---
(From update of attachment 167028)
View in context: https://bugs.webkit.org/attachment.cgi?id=167028&action=review

> Source/WebCore/ChangeLog:12
> +        Since Node::shadowAncestorNode is deprecated, it should not be used.
> +        So replaced the method with Node::shadowHost and Node::isInShadowTree.
> +
> +        No new tests, because this patch is just for refactoring.
> +        All existing tests have already covered the EventHandler's behavior.

The description for this change differs from the description in the Bugzilla bug report. In particular, the Bugzilla bug description implies that there is some kind of error that is caused by the use of shadowAncestorNode() in EventHandler::handleMouseReleaseEvent(). I take it that the Bugzilla bug description is inaccurate?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list