[Webkit-unassigned] [Bug 98401] New: Compile PLUGIN_PROCESS code only when NETSCAPE_PLUGIN_API macro is on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98401

           Summary: Compile PLUGIN_PROCESS code only when
                    NETSCAPE_PLUGIN_API macro is on
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mariusz.g at samsung.com


In webkit2 there are some places where code related with plugin process is guarded by only PLUGIN_PROCESS macro, and in other places with both PLUGIN_PROCESS and NETSCAPE_PLUGIN_API.
Following commit tries to make some cleanup:

"Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
    https://bugs.webkit.org/show_bug.cgi?id=86496"


Files like UIProcess/Plugins/PluginProcessProxy.cpp are being taken to compile always, and inside them at the beginning there is #if ENABLE(PLUGIN_PROCESS) guard. I think that in all places also NETSCAPE_PLUGIN_API check should be added. If plugins are off PLUGIN_PROCESS's code shouldn't be compiled.

Other example:
PluginProxyQt.cpp has guard #if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API), while
PluginProxy.h only #if ENABLE(PLUGIN_PROCESS)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.