[Webkit-unassigned] [Bug 98333] [GTK] Enable inspector by default in GtkLauncher/MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98333





--- Comment #5 from Adrian Perez <aperez at igalia.com>  2012-10-04 04:45:17 PST ---
(In reply to comment #4)
> (From update of attachment 167011 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167011&action=review
> 
> > Tools/GtkLauncher/main.c:492
> > +    g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL);
> 
> Yeah, what Berto said. Also I guess the WK1 and WK2 APIs differ here, otherwise I guess we should try to use the same when thing possible.

WK1 API exposes only the GObject properties, the WK2 API has also the convenience setter/getter functions, so it seemed natural to use them. Would it be better to use also g_object_set when using the WK2 API? (IMHO using the setter is easier on the eyes).

> r- because you need cq to land this, so please re-upload.

Will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.