[Webkit-unassigned] [Bug 98153] [GTK] WebKitWebView doesn't emit notify:favicon when it changes in some cases in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98153





--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-03 04:27:54 PST ---
(In reply to comment #11)
> (From update of attachment 166719 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166719&action=review
> 
> Okay. This looks reasonable. I'd really like Mario to do an informal review before I r+ this though.
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:127
> >> +                    _("Unknown favicon for page %s"), pageURL.utf8().data());
> > 
> > When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> 
> I know that we have agreed in the past to line up the arguments, but it seems that the style bot now complains about this.  We should follow the herd here. Sticking with what we agreed to before will just cause us pain, because the bot will never stop complaining.
> 
> When does this error case happen? I'm a bit confused by the phrase "Unknown favicon for page..."
> 

There are some cases where we don't know anything about the favicon, because the page hasn't been loaded or is being loaded and the icon hasn't been asked yet. Maybe we could rename it to unknown page, there might be a record in the database for he page, but not for the icon yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.