[Webkit-unassigned] [Bug 96768] [GTK] Don't use the C API internally in WebKitWebContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96768





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-03 01:32:56 PST ---
(In reply to comment #5)
> (From update of attachment 166480 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166480&action=review
> 
> This patch looks good to me, in the context of the meta bug 9766.
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:23
> >> +#include "WebResourceCacheManagerProxy.h"
> > 
> > Alphabetical sorting problem.  [build/include_order] [4]
> 
> This doesn't look like a false positive.

Yes, I will fix this before landing.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:167
> > +    priv->geolocationProvider = WebKitGeolocationProvider::create(toAPI(priv->context->geolocationManagerProxy()));
> 
> I was about to comment on this, but I see you addressed the geolocation specific changes in bug 96778.

Yes, this bug is only about WebKitWebContext

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.