[Webkit-unassigned] [Bug 95650] REGRESSION (r123837): Full screen transition is broken at apple.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95650





--- Comment #5 from Jer Noble <jer.noble at apple.com>  2012-10-02 17:21:53 PST ---
(In reply to comment #4)
> From what I can see in the digging I did above, the smooth transition itself is working correctly.
> 
> My gut feel is that there is a workaround in the existing fullscreen code to make the transition smooth. Now that the underlying transition is actually smooth, the assumptions in the workaround are no longer valid, leading to weirdness.
> 
> @jer.noble - does that sound likely? 

The blending is happening at the window server level.  We resize the view to take up the entire screen, then ask for the element's screen rect.  The window server then interpolates from the original screen rect to the final one.

Before r123837, the full screen element's renderer's contentsBox() returned the full screen rect.
After r123837, the full screen element's renderer's contentsBox() returns the original box.

> If not, I suggest we:
> 
>  - revert r123837 (it's a dead simple patch)
>  - someone helps me write a test for the existing fullscreen transition, and we land this

There are some helper functions in Internals that let you do processing between when full screen starts and ends.  That would be a good time to check the bounds of the full screen element.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.