[Webkit-unassigned] [Bug 98002] WebPrintOperationGtk destructor should be virtual

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98002





--- Comment #6 from Alberto Garcia <agarcia at igalia.com>  2012-10-02 12:50:51 PST ---
(In reply to comment #5)
> This patch broke unit tests, see
>
> /webkit2/WebKitPrintOperation/printing-settings: OK
> /webkit2/WebKitWebView/print: OK
> /webkit2/WebKitPrintOperation/print: OK
> /webkit2/WebKitPrintOperation/print-errors:
> (lt-WebKitWebProcess:19919): GLib-CRITICAL **: g_io_channel_write_chars: assertion `channel->is_writeable' failed

The difference now is that the destructor of the derived class is also
called, and that means in particular that
WebPrintOperationGtkUnix::m_printJob is now being destroyed, which is
probably the source of that critical.

I'll investigate what happens.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.