[Webkit-unassigned] [Bug 98153] [GTK] WebKitWebView doesn't emit notify:favicon when it changes in some cases in WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 12:09:42 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=98153





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2012-10-02 12:10:05 PST ---
(From update of attachment 166719)
View in context: https://bugs.webkit.org/attachment.cgi?id=166719&action=review

Okay. This looks reasonable. I'd really like Mario to do an informal review before I r+ this though.

>> Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:127
>> +                    _("Unknown favicon for page %s"), pageURL.utf8().data());
> 
> When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]

I know that we have agreed in the past to line up the arguments, but it seems that the style bot now complains about this.  We should follow the herd here. Sticking with what we agreed to before will just cause us pain, because the bot will never stop complaining.

When does this error case happen? I'm a bit confused by the phrase "Unknown favicon for page..."

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:270
> +static void webkitWebViewCancelFavicon(WebKitWebView* webView)

webkitWebViewCancelFaviconRequest?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:288
>  static void iconReadyCallback(WebKitFaviconDatabase *database, const char *uri, WebKitWebView *webView)

Do you mind also fixing the asterisks here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list