[Webkit-unassigned] [Bug 98153] [GTK] WebKitWebView doesn't emit notify:favicon when it changes in some cases in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98153





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-02 06:55:03 PST ---
(In reply to comment #5)
> (From update of attachment 166680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166680&action=review
> 
> The patch looks good to me. Only concern I have is whether it would be needed to write / extend a unit test for it.

Unit tests are currently broken indeed, but I don't know why, I'll look at it.

> > Source/WebKit2/ChangeLog:23
> > +        known by the database and it doesn't have a favicon.
> 
> Good catch
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1253
> > +static void faviconReadyCallback(GObject* object, GAsyncResult* result, gpointer userData)
> 
> Nit. I would probably rename this function to better reflect is the async callback for _get_favicon() and not the handler for the icon-ready signal (as it seems to suggest)

You are right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.