[Webkit-unassigned] [Bug 98063] [GTK] [WK2] Add favicon support to the MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98063


Alberto Garcia <agarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166631|0                           |1
        is obsolete|                            |
 Attachment #166631|review?                     |
               Flag|                            |
 Attachment #166669|                            |review?
               Flag|                            |




--- Comment #5 from Alberto Garcia <agarcia at igalia.com>  2012-10-02 04:49:53 PST ---
Created an attachment (id=166669)
 --> (https://bugs.webkit.org/attachment.cgi?id=166669&action=review)
Patch v2

(In reply to comment #2)
> I guess you should also unref the favicon pixbuf in finalize().

> Use a single line here:
> cairo_surface_t *surface = webkit_web_view_get_favicon(window->webView);

> > +    g_signal_connect(window->uriEntry, "notify::text", G_CALLBACK(uriEntryTextChanged), (gpointer)window);
> Don't use the gpointer cast, it's not needed

Ok, here's the new patch with these three changes.

I also decided not to clear the icon when the URI entry is changed. So
for this to work correctly, WebKitWebView has to emit notify::favicon
also when a new page is loaded and it has no favicon.

The emission of that signal need anyway to be changed since it's not
being emitted in most cases at the moment, but it should not affect
the MiniBrowser code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.