[Webkit-unassigned] [Bug 98063] [GTK] [WK2] Add favicon support to the MiniBrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 02:32:35 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=98063





--- Comment #4 from Alberto Garcia <agarcia at igalia.com>  2012-10-02 02:32:59 PST ---
(In reply to comment #3)

> Just a small nit. WebKit coding style prefers early returns for these cases. So better 
> 
> if (!window->favicon)
>     return;

If you're talking about faviconChanged(), there we want to clear the
favicon if it's NULL, not just return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list