[Webkit-unassigned] [Bug 98108] Correct detection of context type in WorldContextHandle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98108





--- Comment #6 from Kentaro Hara <haraken at chromium.org>  2012-10-01 22:49:44 PST ---
(In reply to comment #3)
> (From update of attachment 166596 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166596&action=review
> 
> > UNLIKELY() would not be helpful in .cpp. You can remove it.
> 
> Actually, UNLIKELY and LIKELY don't do anything on the compilers and architectures we use.  We might want to just remove them from the project.

(As far as I remember) I've observed that the generated assembly changes in clang and it affects performance (e.g. https://bugs.webkit.org/attachment.cgi?id=166147&action=review). A branch marked as UNLIKELY() is likely to be placed after the other branch (to place hot call paths as sequentially as possible).

Either way, LIKELY/UNLIKELY in outline functions would have no meaning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.