[Webkit-unassigned] [Bug 98108] Correct detection of context type in WorldContextHandle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98108





--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2012-10-01 21:06:48 PST ---
(From update of attachment 166596)
View in context: https://bugs.webkit.org/attachment.cgi?id=166596&action=review

Abarth: review?

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:190
> +    if (!wrapper->IsNumber() && !wrapper->IsExternal())

!wrapper->IsNumber() || !wrapper->IsExternal() ?

> Source/WebCore/bindings/v8/WorldContextHandle.cpp:50
> +    // FIXME: This probably shouldn't be allowed to happen.
>      if (v8::Context::InContext()) {

In what situation do you think this can happen?

> Source/WebCore/bindings/v8/WorldContextHandle.cpp:60
> +    if (UNLIKELY(typeInfo == &V8DedicatedWorkerContext::info)) {

UNLIKELY() would not be helpful in .cpp. You can remove it.

> Source/WebCore/bindings/v8/WorldContextHandle.cpp:65
> +    if (UNLIKELY(typeInfo == &V8SharedWorkerContext::info)) {

Ditto.

> Source/WebCore/bindings/v8/WorldContextHandle.cpp:73
> +    if (UNLIKELY(typeInfo != &V8DOMWindow::info)) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.