[Webkit-unassigned] [Bug 91187] [EFL] Add dummy implementation of File system API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91187





--- Comment #17 from Kinuko Yasuda <kinuko at chromium.org>  2012-10-01 00:40:48 PST ---
(From update of attachment 166172)
View in context: https://bugs.webkit.org/attachment.cgi?id=166172&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Add dummy implementation of File system API.

nit: dummy -> skeleton might sound better/appropriate.

>>>> Source/WebCore/Modules/filesystem/LocalFileSystem.cpp:80
>>>> +#if !PLATFORM(EFL)
>>> 
>>> Why do you disable this functions on EFL port ?
>> 
>> As you can see at https://bugs.webkit.org/show_bug.cgi?id=79193, 
>> I'm planning to re-implement those functions in AsyncFileSystemEfl.cpp.
>> 
>> To make the path of the file system, FileSystemType is needed.
>> But, FileSystemType is not a parameter of AsyncFileSystem::openFileSystem.
>> So, I need to re-implement LocalFileSystem::requestFileSystem function to make
>> proper file system path before calling AsyncFileSystem::openFileSystem.
>> 
>> Same as LocalFileSystem::readFileSystem.
> 
> IMO, it would be good if you re-implement functions you need in LocalFileSystemEfl.cpp.

If having no type argument in openFileSystem is the blocking issue I think you could probably change its signature and remove the FIXME comment at the method (in a separate patch), as no live code (at least for submitted ones) implements the method yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.