[Webkit-unassigned] [Bug 103606] WebGL: Add a class to abstract the status of the Image in texImage2D() and texSubImage2D()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103606


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176925|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #5 from Kenneth Russell <kbr at google.com>  2012-11-30 14:22:27 PST ---
(From update of attachment 176925)
View in context: https://bugs.webkit.org/attachment.cgi?id=176925&action=review

Looks great. Thank you for pushing through this change. A couple of minor nits which are not blockers for committing in my opinion. If you wouldn't mind, please clean them up in a subsequent patch. Submitting this to the commit queue for you. r=me

> Source/WebCore/platform/graphics/GraphicsContext3D.h:877
> +    // according to the given format and type, and obeying the flipY and premultiplyAlpha flags.

Typo: premultiplyAlpha -> AlphaOp

> Source/WebCore/platform/graphics/GraphicsContext3D.h:900
> +        // Return true upon success

Please use complete sentences in comments (end each sentence with a period).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.