[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103513


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176977|review?                     |review-
               Flag|                            |




--- Comment #33 from Pavel Feldman <pfeldman at chromium.org>  2012-11-30 14:03:29 PST ---
(From update of attachment 176977)
View in context: https://bugs.webkit.org/attachment.cgi?id=176977&action=review

Overall, it looks good, I think it is Ok to proceed with the test.

> Source/WebCore/inspector/Inspector.json:3264
> +                "hidden": true

nit: here and below, no need to hide methods of the hidden domain.

> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:218
> +    const RenderLayer* renderLayer = m_idToLayer.get(layerId);

this can be 0 and you should return an error for this.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:514
> +    InspectorInstrumentation::layerTreeDidChange(this->page());

just page() ?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:520
> +    InspectorInstrumentation::renderLayerDestroyed(this->page(), renderLayer);

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.