[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #10 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-30 01:05:11 PST ---
(From update of attachment 176902)
View in context: https://bugs.webkit.org/attachment.cgi?id=176902&action=review

On a side node: some work has been ongoing in webkit, so make sure that when the deviceScaleFactor != 1, we don't end up scaling the canvas. Are you aware of this work and how does it work with your implementation

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:85
> +    , m_accelerated(false)

isAccelerated is used elsewhere

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.h:71
> +    void setAccelerated(bool accelerated) { m_accelerated = accelerated; }

Why not be consistent with other ports?

GraphicsContext::setIsAcceleratedContext(bool isAccelerated)
Source/WebCore/platform/graphics/GraphicsContext.h:        void setIsAcceleratedContext(bool);

> Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.cpp:34
> +Canvas2DLayerEfl::Canvas2DLayerEfl(ImageBuffer* buffer, IntSize& size)

why not const IntSize& ?

> Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.h:33
> +
> +class Canvas2DLayerEfl :

Is this really EFL specific or cairo specific?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.