[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704


Christophe Dumez <christophe.dumez at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.dumez at intel.com




--- Comment #8 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-29 22:55:37 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=176902&action=review

> Source/WebCore/platform/graphics/ImageBuffer.h:124
> +        cairo_surface_t* getSurface() const { return m_data.m_surface; }

We usually name getters such as surface() directly, not getSurface().
Also, the coding style was recently altered so that functions returning non-const pointers should not be const.

> Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.cpp:29
> +PassRefPtr<Canvas2DLayerEfl> Canvas2DLayerEfl::create(ImageBuffer* buffer, IntSize& size)

size argument should probably be const

> Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.cpp:34
> +Canvas2DLayerEfl::Canvas2DLayerEfl(ImageBuffer* buffer, IntSize& size)

Ditto.

> Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.h:37
> +    , public RefCounted<Canvas2DLayerEfl> {

Looks like the comma should be inside the #if otherwise it won't build if TEXTURE_MAPPER_GL is not used.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.