[Webkit-unassigned] [Bug 103649] [BlackBerry] Cookies in private mode should not have access to public cookies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 10:30:15 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103649


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176755|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-11-29 10:32:32 PST ---
(From update of attachment 176755)
View in context: https://bugs.webkit.org/attachment.cgi?id=176755&action=review

Otto agreed to clean it up some more.

> Source/WebCore/platform/blackberry/CookieManager.cpp:512
>      if (!mode) {

It would be more readable to have it called privateMode instead of mode, but your patch is not related to that.

> Source/WebCore/platform/blackberry/CookieManager.cpp:516
> +        removeAllCookies(DoNotRemoveFromBackingStore);

We always do this...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list