[Webkit-unassigned] [Bug 103335] [CSS Grid Layout] Support all specified breadth size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103335


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176269|0                           |1
        is obsolete|                            |




--- Comment #5 from Xan Lopez <xan.lopez at gmail.com>  2012-11-29 10:20:16 PST ---
Created an attachment (id=176754)
 --> (https://bugs.webkit.org/attachment.cgi?id=176754&action=review)
breadth-types.diff

OK, another RFC patch.

Updates:

- I came to the conclusion that in CSSComputedStyleDeclaration we *really* had to use valueForLength to get the proper dump results, so I'm doing that (had to pass RenderView through a couple of methods).
- Not using .isPercent() since it also includes the 'Calc' type, which must be handled separately. Added a comment for this.
- Also using valueForLength() in RenderGrid, same reasons. Not sure of whether the max width or height values I'm using make sense, to be honest (I think the width one at least does).
- Tried to add tests for all this as suggested, including a new layout test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.