[Webkit-unassigned] [Bug 103642] Add support for generic types in arrays and sequences to the code generators

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103642





--- Comment #3 from Adam Barth <abarth at webkit.org>  2012-11-29 10:05:27 PST ---
(From update of attachment 176740)
View in context: https://bugs.webkit.org/attachment.cgi?id=176740&action=review

This looks good to me.  We might want to have haraken take a look as well.  It looks like you have some compile errors on gtk and efl.

> Source/WebCore/bindings/js/JSDOMBinding.h:433
> +        return result;

Does this mean we copy the array and churn the refcount, or are we smart enough to move it?  We might want to use an out parameter to avoid the extra memcpy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.