[Webkit-unassigned] [Bug 103510] Reduce the children repaints when moved multiple times during the layout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103510





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-11-29 00:33:37 PST ---
(In reply to comment #2)
> (From update of attachment 176463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176463&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        No new tests. Covered by existing tests in css3/flexbox.
> 
> Can you make a repaint test that shows the improvement?

Sure, I'll try.

> > Source/WebCore/rendering/RenderFlexibleBox.h:81
> > +    typedef WTF::HashMap<const RenderBox*, LayoutRect> ChildrenFrameRect;
> 
> Can we use a Vector<LayoutRect> instead of a HashMap?

I used a hash map, because I'm iterating the children using the flexbox order, I'm not sure if it's important to repaint in that order, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.