[Webkit-unassigned] [Bug 103581] run-perf-tests --chromium-android should not require adb in my path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103581





--- Comment #2 from Peter Beverloo <peter at chromium.org>  2012-11-28 17:53:24 PST ---
The "adb" tool is available in Source/WebKit/chromium/third_party/android_tools/sdk/ for Chromium-Android checkouts. I agree that we should get rid of this.

We can add an _path_to_adb() method to ChromiumAndroidPort and use this both for ChromiumAndroidPort._get_devices() and for ChromiumAndroidDriver.__init__ (for self._adb_command).

run-api-tests and run-chromium-webkit-unit-tests have the same dependency right now. There, we may have to set the PATH variable before invoking Chromium's run_tests.py.

Not sure if you're going to work on this, otherwise I'll upload a patch tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.