[Webkit-unassigned] [Bug 103484] IndexedDB: Implement IndexedDB bindings for JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103484





--- Comment #2 from Joshua Bell <jsbell at chromium.org>  2012-11-28 11:52:31 PST ---
(From update of attachment 176519)
View in context: https://bugs.webkit.org/attachment.cgi?id=176519&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Please include more of an explanation of the changes after the Reviewed line.

> Source/WebCore/ChangeLog:8
> +        Tests: storage/indexeddb/*

Can you indicate roughly how many tests pass/fail with just this patch when INDEXED_DATABASE is enabled locally?

> Source/WebCore/ChangeLog:13
> +        * Modules/indexeddb/IDBVersionChangeRequest.idl:

FYI, IDBVersionChangeRequest should be going away shortly (now that setVersion is gone, deleteDatabase can switch over to IDBOpenDBRequest). But that shouldn't block landing this.

> Source/WebCore/ChangeLog:23
> +        * bindings/js/IDBBindingUtilities.cpp:

You could mention here that these all match the v8 implementations.

> Source/WebCore/bindings/js/JSIDBOpenDBRequestCustom.cpp:40
> +void JSIDBOpenDBRequest::visitChildren(JSCell* cell, JSC::SlotVisitor& visitor)

I don't know the JSC binding code well but after a brief glance it looks like this is doing the right thing. Unfortunate that this boilerplate is needed; we should probably put a bug in to add WebKitIDL attributes to autogenerate the different visitChildren variations (there only seem to be a few different patterns).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.