[Webkit-unassigned] [Bug 102689] [WinCairo] Crash when requesting favicon.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102689





--- Comment #17 from peavo at outlook.com  2012-11-28 04:43:52 PST ---
(In reply to comment #14)
> (From update of attachment 176223 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176223&action=review
> 
> Looks good.  Do you have committer rights?
> 

No, sorry, I don't have committer rights :)

> > Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:35
> > +// for and image with empty frames (BitmapImage::frameAtIndex(i) return null), WebKit Bug 102689.
> 
> This should be "an image"
> 
> > Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:54
> > +    int* bits = new int[16*16];
> 
> Why not just declare this on the stack, rather than do a new/delete?  It's a small buffer.

Submitted updated patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.