[Webkit-unassigned] [Bug 103335] [CSS Grid Layout] Support all specified breadth size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103335





--- Comment #3 from Julien Chaffraix <jchaffraix at webkit.org>  2012-11-27 17:04:36 PST ---
(From update of attachment 176269)
View in context: https://bugs.webkit.org/attachment.cgi?id=176269&action=review

> Source/WebCore/rendering/RenderGrid.cpp:145
> +        if (trackStyles[i].isSpecified())
>              track.m_usedBreadth = trackStyles[i].getFloatValue();

Actually this is completely wrong sorry for missing that.

You need to use valueForLength (see css/LengthFunctions.h) to do the conversion: this patch would convert 15% into 15px :(.

What's tricky is what to pass in as the |maximumValue| for the conversion. You should have computed your logicalWidth already so it's easy for logical width or column direction. For logical height or row direction, you will need to infer it from the style using computeContentLogicalHeight or some similar function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.