[Webkit-unassigned] [Bug 102828] r134080 causes heap problem on linux systems where PAGESIZE != 4096

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102828


Mark Hahnenberg <mhahnenberg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175259|review?                     |review-
               Flag|                            |




--- Comment #2 from Mark Hahnenberg <mhahnenberg at apple.com>  2012-11-26 13:00:43 PST ---
(From update of attachment 175259)
View in context: https://bugs.webkit.org/attachment.cgi?id=175259&action=review

I'm somewhat confused as to why a different page size makes things segfault. Where exactly did it segfault? I wouldn't be opposed to making the Region size variable, e.g. 16 * WTF::pageSize() or something like that.

> Source/JavaScriptCore/heap/MarkStack.cpp:48
> +#if OS(LINUX) && COMPILER(GCC)

Instead of putting a bunch of nasty ifdefs everywhere, maybe you could use WTF::pageSize()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.