[Webkit-unassigned] [Bug 103151] [GStreamer] verify if GStreamer was previously initialized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103151





--- Comment #8 from Philippe Normand <pnormand at igalia.com>  2012-11-26 11:25:20 PST ---
(From update of attachment 176038)
View in context: https://bugs.webkit.org/attachment.cgi?id=176038&action=review

Ok almost perfect!

> Source/WebCore/ChangeLog:17
> +        No new tests (OOPS!).

I think the commit queue will not like the OOPS. I think I mentioned previously that you can state existing media tests cover this change.

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:33
> +    if (gst_is_initialized ())

Can you please remove the space after the function name? :)

> Tools/ChangeLog:14
> +        This approach is not valid for MiniBrowser because it uses WebKit2,
> +        where the GStreamer backend lives in the web process, which is
> +        different from the UI process.

Nice explanation!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.