[Webkit-unassigned] [Bug 102689] [WinCairo] Crash when requesting favicon.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102689





--- Comment #10 from peavo at outlook.com  2012-11-26 09:29:43 PST ---
(In reply to comment #8)
> (From update of attachment 175822 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175822&action=review
> 
> >>> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:98
> >>> +        if (!frameAtIndex(i))
> >> 
> >> Is it expected that a frame might be null? Maybe we have an underlying problem in frame handling that is allowing null images to pass through.
> > 
> > I just checked the CG implementation, and they perform similar null checks. So I think this is the right approach.
> 
> This fix was part of Bug 68753, which I have landed and closed.

I believe both patches are needed. We still need to check the return value of
frameAtIndex() to avoid dereferencing a null pointer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.