[Webkit-unassigned] [Bug 103175] Make renderer construction less generic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103175





--- Comment #13 from Antti Koivisto <koivisto at iki.fi>  2012-11-25 09:01:46 PST ---
(In reply to comment #10)
> You should remove isElementNode() check in moveToFlowThreadIfNeeded() since we never call it on non-elements with this patch.

Done.

> Can we either rename this elementRendererIsNeeded to match the new createRendererForElementIfNeeded or leave the method name alone for createRendererIfNeeded (as you have textRendererIsNeeded and createTextRenderer)? We lose the parity in the methods from this patch.

We don't usually prefix member functions with the class type. Only reason I did it for Text was to avoid confusing these non-virtual calls with with the virtual Element functions.

> The old version of this method was shorter and seemed easier to understand.

Shortness is a non-goal and I obviously disagree with the 'easier to understand' part.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.