[Webkit-unassigned] [Bug 101349] [GStreamer] Floating reference handling fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101349





--- Comment #19 from Thiago Santos <thiago.sousa.santos at collabora.com>  2012-11-25 04:16:56 PST ---
(In reply to comment #18)
> (From update of attachment 175872 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175872&action=review
> 
> Awesome, thanks Thiago! Now just the ChangeLog to fix up and the missing include to add!
> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:181
> > +    priv->sourcePad = webkitGstGhostPadFromStaticTemplate(&srcTemplate, "src", 0);
> 
> GStreamerVersioning.h include is missing I think. BTW this code is not yet enabled by default in the build, you need to use the --web-audio build-webkit option. I have a patch almost ready for the 1.0 port to upload soon :)

Great. So I'm only adding the missing include as trying to build this file with gstreamer 1.0 causes errors as it has not been ported yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.