[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102853


Laszlo Gombos <laszlo.gombos at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laszlo.gombos at webkit.org




--- Comment #5 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-11-24 18:14:14 PST ---
(In reply to comment #4)

> > >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:32
> > >> +#include <EWebKit2.h>
> > > 
> > > ditto.
> > 
> > So? This file is using Ewk types so it should include EWebKit2.h. Relying on other headers includes is bad practice.

> I refactored EWK2UnitTestBase.h to include the EWK2UnitTestEnvironment.h, Ecore.h, Eina.h headers in http://trac.webkit.org/changeset/135349, as they are used commonly in API test cases.


I agree with Christophe in general that relying on other header includes is bad practice, but when it is justified it might make sense to break the general rule. As an example most WebKit files rely on Platform.h to include Compiler.h - as we made an exception with config.h (and even added this exception to the style checker). 

The idea of EWK2UnitTestBase.h is similar to config.h - EWK2UnitTestBase.h should be included first in every EFL API test-case. I do not feel strongly about EWK2UnitTestBase.h, but wanted to take this chance to explain why I supported r135349. We should either follow this new practice going forward for future API tests as well or revert r135349 for consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.