[Webkit-unassigned] [Bug 103175] Make renderer construction less generic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103175





--- Comment #8 from Eric Seidel <eric at webkit.org>  2012-11-24 11:30:47 PST ---
(From update of attachment 175855)
View in context: https://bugs.webkit.org/attachment.cgi?id=175855&action=review

Thank you *very* much for such a clear explanation.  And thank you again for working on this.  core rendering like this still needs a lot of love. :(

> Source/WebCore/dom/CharacterData.cpp:95
> +        toText(this)->updateTextRenderer(oldLength, 0);

This is such a horribly cryptic method name/calling-convention.  (Not your fault.  Just hope we make it clearer some day.)

> Source/WebCore/dom/Element.cpp:1102
> +    return (document()->documentElement() == this) || (context.style()->display() != NONE);

I didn't know that the body always got a render?  Interesting.

> Source/WebCore/dom/Text.cpp:311
> +    if (!textRenderer || !textRendererIsNeeded(NodeRenderingContext(this, textRenderer->style()))) {
> +        reattach();

I'm slightly confused by this re-attach here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.