[Webkit-unassigned] [Bug 103175] Make renderer construction less generic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103175


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dglazkov at chromium.org,
                   |                            |esprehn at chromium.org,
                   |                            |jchaffraix at webkit.org




--- Comment #3 from Eric Seidel <eric at webkit.org>  2012-11-24 08:31:21 PST ---
I guess in my initial reading, I'm not really for or against this change.  It doesn't seem much simpler to me.  But I like the idea of someone trying to make all of this ancient code simpler/faster.  I'm just not sure what your end goal here is. :)

I agree that there are only two cases of interest (text and element nodes), and that should always be the case.  So perhaps special casing them (as you've done here) instead of generic dispatch on Node is a better approach.

I guess I'm just asking to learn more of your thoughts/plans.  :)

I'm happy to r+ this patch once understanding a bit more context.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.